From 715dcb8ec52f224b0745527087d5897acf78fd4b Mon Sep 17 00:00:00 2001 From: mcarton Date: Fri, 15 Jan 2016 15:51:26 +0100 Subject: [PATCH] Add an is_empty method to types with a len one MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Fix all Clippy’s len_without_is_empty warnings. --- src/cargo/core/package.rs | 4 ++++ src/cargo/core/source.rs | 4 ++++ src/cargo/util/dependency_queue.rs | 5 +++++ 3 files changed, 13 insertions(+) diff --git a/src/cargo/core/package.rs b/src/cargo/core/package.rs index 7de725ebb..45242b076 100644 --- a/src/cargo/core/package.rs +++ b/src/cargo/core/package.rs @@ -129,6 +129,10 @@ impl PackageSet { PackageSet { packages: packages.to_vec() } } + pub fn is_empty(&self) -> bool { + self.packages.is_empty() + } + pub fn len(&self) -> usize { self.packages.len() } diff --git a/src/cargo/core/source.rs b/src/cargo/core/source.rs index fc5765287..74446f0eb 100644 --- a/src/cargo/core/source.rs +++ b/src/cargo/core/source.rs @@ -419,6 +419,10 @@ impl<'src> SourceMap<'src> { self.map.insert(id.clone(), source); } + pub fn is_empty(&self) -> bool { + self.map.is_empty() + } + pub fn len(&self) -> usize { self.map.len() } diff --git a/src/cargo/util/dependency_queue.rs b/src/cargo/util/dependency_queue.rs index 499521bb3..78d48232d 100644 --- a/src/cargo/util/dependency_queue.rs +++ b/src/cargo/util/dependency_queue.rs @@ -110,6 +110,11 @@ impl DependencyQueue { Some((fresh, key, data)) } + /// Returns whether there are remaining packages to be built. + pub fn is_empty(&self) -> bool { + self.dep_map.is_empty() && self.pending.is_empty() + } + /// Returns the number of remaining packages to be built. pub fn len(&self) -> usize { self.dep_map.len() + self.pending.len() -- 2.30.2